Feature request: SRT files

[ChefGregS]

Would it be possible to have Filebot handle .srt files better?

I have some files that have anywhere from 2-10 .srt files included. As it is, Filebot changes the name to the same as the movie (the way it should) but then rips off any country code associated with the file.

Example:

This movie.mp4
This movie.eng.srt
This movie.fre.srt
This movie.rus.srt
This movie.eng.SDH.srt

Currently, it would strip everything after This movie off. This not only removes the country codes but then gives the error that you have 4 files with the same name.

Seems to me (and maybe I'm wrong) that it would be as simple as checking if the extension is .srt and then looking for what precedes it. Either have the 2 and 3 letter codes included in a database or allow the user (me) to tell Filebot what to look for. In my case it should keep everything from ]. til the end.

Example of my file names:

Code: Select all

High Plains Drifter [1973, R, 105 Min] [Clint Eastwood, Verna Bloom, Marianna Hill] [Western] [1080p, AAC@6ch].mp4
High Plains Drifter [1973, R, 105 Min] [Clint Eastwood, Verna Bloom, Marianna Hill] [Western] [1080p, EAC3@6ch].eng.srt
High Plains Drifter [1973, R, 105 Min] [Clint Eastwood, Verna Bloom, Marianna Hill] [Western] [1080p, EAC3@6ch].fre.srt
High Plains Drifter [1973, R, 105 Min] [Clint Eastwood, Verna Bloom, Marianna Hill] [Western] [1080p, EAC3@6ch].ger.srt

So if the file extension is .srt keep everything back until it hits the ].

There are probably a number of ways to do this..... But I know it would be a great feature to have.

Thanks

Greg

[rednoah]

What format are you using? The {subt} binding should work out of the box to give you the ".eng" subtitle suffix for subtitle files.

[ChefGregS]

Sweet!!!!!!!!!!!! WOW, when I think of how many hours I have spent HAND editing those files.. UGH!!! Works PERFECTLY!!!

Greg

[rednoah]

If you ever find yourself HAND doing anything, let me know and ask, cause FileBot might just have some tricks ups it's sleeve to help you save manual labour.

[ChefGregS]

I was going to post this suggestion/question about a year ago...kept forgetting. LOL Since I just reran ALL my almost 3000 movies recently I was doing it again.... I just started re-encoding low quality movies to be better audio and video and ran into several that had 6-10 srt files each....which made me think about it again. It's the only thing I really ever had to do by hand since finding Filebot...but now I know.

As always....you rock!

Greg

[ChefGregS]

I am back on this issue. This one is not a huge deal but I did notice that Filebot has never (at least for me...lol) handled the SDH subs.. Am I missing something simple? Or, if not, can it be added as a updated feature soon? I am guessing it already does it but I have not sat and studied the coding in a very long time so maybe I'm just missing this fix.

Greg

My current script:

Code: Select all

{n =~ 'X-Rated' ? 'M:/Movies P' : vf == /2160p/ ? 'N:/Movies 4K' : vf =~ /1080p|720p/ ? 'M:/Movies HD' : 'M:/Movies'}/{n.upperInitial().colon(' - ').replace('?', '!')} {' (' + fn.matchAll(/korsubs|deleted.scenes|extended|uncensored|remastered|unrated|uncut|directors.cut|special.edition|redux|UHD|theatrical/)*.upperInitial()*.lowerTrail().sort().join(', ').replaceAll(/[._]/, " ") + ')'} {any{' Part '+pi}{null}|uncut|director} ({y}) {fn.match(/3D/)}/{n.upperInitial().colon(' - ').replace('?', '!')} {' (' + fn.matchAll(/korsubs|deleted.scenes|extended|uncensored|remastered|unrated|uncut|directors.cut|special.edition|redux|UHD|theatrical/)*.upperInitial()*.lowerTrail().sort().join(', ').replaceAll(/[._]/, " ") + ')'} {any{' Part '+pi}{null}} [{y}, {any{csv('M:/replacecert1.csv').get(certification)}{certification}{"NR"} }, {runtime} Min] {[actors.take(3).join(', ')]} {[genres.take(3).join(', ')]} [{fn.match(/3D/)+', '}{"$vf, $ac@$af"}]{subt}

[rednoah]

What are SDH subs?

[ChefGregS]

SDH subs are the sub files that contain extra information. Music Playing, Crowd Yelling, Thunder crashing far off, Boy Snickering, etc... These are the actual files for deaf people. So they can get context of the environment and know more of what is going on. They often also identify the speaker for each quote, especially when multiple are speaking at once or very quickly so they wouldn't know who is saying what unless the text simply exited the screen with every camera change to a new person...

Does that make sense?

Greg

Normal Eng.srt:

Code: Select all

1
00:00:59,017 --> 00:01:00,632
Agnarr: Anna. Elsa.

2
00:01:00,769 --> 00:01:01,975
Iduna: Bedtime soon.

3
00:01:02,187 --> 00:01:03,973
Uh-oh. The Princess is trapped

4
00:01:04,022 --> 00:01:05,603
in the snow goblin's evil spell.

5
00:01:05,732 --> 00:01:08,394
Quick, Elsa! Make a prince!
A fancy one!

6
00:01:08,485 --> 00:01:10,646
Oh, no!
The prince is trapped, too.

7
00:01:10,779 --> 00:01:12,269
Who cares about danger

8
00:01:12,322 --> 00:01:13,437
when there's love?

9
00:01:13,490 --> 00:01:15,151
Ugh, Anna. Bleugh!

10
00:01:15,534 --> 00:01:17,240
Kissing won't save the forest.

11
00:01:17,286 --> 00:01:19,618
The lost fairies cry out.

12
00:01:21,039 --> 00:01:22,183
What sound does a giraffe make?

13
00:01:22,207 --> 00:01:23,287
Never mind.

14
00:01:23,333 --> 00:01:24,539
They wake the fairy queen...

15
00:01:24,668 --> 00:01:27,375
Who breaks the spell
and saves everyone!

SDH.eng.srt

Code: Select all

1
00:00:06,965 --> 00:00:09,001
(Orchestral music playing)

2
00:00:10,093 --> 00:00:12,129
(Chorus chanting yoik)

3
00:00:51,009 --> 00:00:52,795
(Soft music playing)

4
00:00:59,017 --> 00:01:00,632
Agnarr: Anna. Elsa.

5
00:01:00,769 --> 00:01:01,975
Iduna: Bedtime soon.

6
00:01:02,187 --> 00:01:03,973
Uh-oh. The Princess is trapped

7
00:01:04,022 --> 00:01:05,603
in the snow goblin's evil spell.

8
00:01:05,732 --> 00:01:08,394
Quick, Elsa! Make a prince!
A fancy one!

9
00:01:08,485 --> 00:01:10,646
Oh, no!
The prince is trapped, too.

10
00:01:10,779 --> 00:01:12,269
(In deep voice)
Who cares about danger

11
00:01:12,322 --> 00:01:13,437
when there's love?

12
00:01:13,490 --> 00:01:15,151
- (Mimics kissing)
- Ugh, Anna. Bleugh!

13
00:01:15,534 --> 00:01:17,240
Kissing won't save the forest.

14
00:01:17,286 --> 00:01:19,618
- (Young Anna giggles)
- The lost fairies cry out.

15
00:01:19,663 --> 00:01:20,994
(Mimics trumpeting)

16
00:01:21,039 --> 00:01:22,183
What sound does a giraffe make?

17
00:01:22,207 --> 00:01:23,287
- (Mumbles)
- Never mind.

18
00:01:23,333 --> 00:01:24,539
They wake the fairy queen...

19
00:01:24,668 --> 00:01:27,375
Who breaks the spell
and saves everyone!

20
00:01:27,504 --> 00:01:29,335
- And they all get married!
- (Giggles)

Here is how they are in the file system:

Frozen II [2019, G, 104 Min] [Kristen Bell, Idina Menzel, Jonathan Groff] [Animation, Family, Adventure] [2160p, AAC@6ch].eng.srt

Frozen II [2019, G, 104 Min] [Kristen Bell, Idina Menzel, Jonathan Groff] [Animation, Family, Adventure] [2160p, AAC@6ch].SDH.eng.srt

[rednoah]

I guess you could just match SDH (or any other arbitrary text pattern) from the file name:

Code: Select all

{subt}{'-'+fn.match(/SDH/)}

Note that {subt} implicitly supports standard naming such as *.eng-forced.srt, *.eng-HI.srt, *.eng-SHD.srt but not *.SDH.eng.srt.

[kim]

This is missing in the Docs
https://www.filebot.net/docs/api/index.html

[ChefGregS]

I guess you could just match SDH (or any other arbitrary text pattern) from the file name:

Code: Select all

{subt}{'-'+fn.match(/SDH/)}

Note that {subt} implicitly supports standard naming such as *.eng-forced.srt, *.eng-HI.srt, *.eng-SHD.srt but not *.SDH.eng.srt.

OH!!! So it would handle it automatically had it been formatted correctly in the file name to begin with?? ( eng-SDH.srt) Did you mean to type SDH or SHD in your post? Because SDH is the correct form. NOT SHD.

So...no matter a mistype or not...the correct format for FileBot to correctly add/keep the subtitle info means that the file extension(s) needs to be in the format of:
filename.language_code.srt or filename.language_code-(Forced)(HI)(SDH).srt?

Greg

[rednoah]

This is missing in the Docs
https://www.filebot.net/docs/api/index.html

"This" referring to what exactly? What kind of code-level documentation would you expect specifically for the topic at hand? The source code for subt, fn and String.match() is should all there. The forced|HI|SDH pattern is in the external *.properties file, so that's not code, so javadoc wouldn't include it.

[rednoah]

So...no matter a mistype or not...the correct format for FileBot to correctly add/keep the subtitle info means that the file extension(s) needs to be in the format of:
filename.language_code.srt or filename.language_code-(Forced)(HI)(SDH).srt?

Yes, all of these will work:

Code: Select all

Avatar.eng.srt
Avatar.eng-forced.srt
Avatar.eng-SDH.srt

[ChefGregS]

Yes, all of these will work:

Code: Select all

Avatar.eng.srt
Avatar.eng-forced.srt
Avatar.eng-SDH.srt

Got it. I did a few tests and it does in fact work perfectly. I just need to pay attention as it seems almost every SDH version of a .srt file is done as filename.sdh.eng.srt. So I will just make sure to check and fix them to the correct form of filename.eng-sdh.srt

Thanks as always!!!

Greg

[kim]

My point was, we need better documentation like the "docs" in a ONE place to make it easy to find needed info.
It's to hard to find info by only searching the forum (even if you know what you are looking for).

what "external *.properties file" and how can I know to look in that file e.g. when renaming subs ?
(I use Win store version)

This is missing in the Docs
https://www.filebot.net/docs/api/index.html

"This" referring to what exactly? What kind of code-level documentation would you expect specifically for the topic at hand? The source code for subt, fn and String.match() is should all there. The forced|HI|SDH pattern is in the external *.properties file, so that's not code, so javadoc wouldn't include it.

[rednoah]

I see. A complete manual is planned, but it's going to be a book with hundreds of pages, so it's a bit of a monumental effort at first, and will require continues refinement, and so priorities are elsewhere for now.


EDIT:

That being said. I am looking for a talented technical writer / advanced FileBot user that is willing to take this on as a paid job / part-time job for a few months. Though I am rather picky about it.

[kim]

So do I have access to this "external *.properties file" ?

You could make a manual sample and then give Filebot license for there work there in forum

[rednoah]

Sorry, these patterns are built-in and can't be changed. A manual would show examples of supported use cases, but not necessarily include advanced technical documentation on implementation details, so it might not be what you're looking for.

Complimentary licenses are freely available to anyone who wants to help out in any way. I'd expect a professional technical writer to charge a lot more than $6 though even if just for a day of work.

[ChefGregS]

Just ran into a file with a great number of SRT files. Many languages. This brought up a new question... and I'm guessing the answer is just as simple as eng-sdh but thought I would ask anyway.

FYI, I do try to use 3 character language extensions whenever possible. eng instead of en, rus instead of ru.

I am finding a few versions that I need help with. I have these types and not sure exactly how to handle them:
Brazilian.por.srt
European.por.srt
European.spa.srt
Latin American.spa.srt
Simplified.chi.srt
Traditional.shi.srt

Once I had a site bookmarked (gone now for some reason) with what I thought was every version of country code for use with .srt files but I can't seem to find it. Not sure it would help in this case anyway but I'll keep trying to find the right search words to find it again.

However, if/when I find it, what do I do with the above files?

Greg

PS: This page: https://www.facebook.com/help/1528795707381162 could work (they use 2 letter instead of 3) and thus I am not sure what the additional would be. And it uses ES for spanish when the correct 3 letter code is SPA. Thus, this gets really confusing.

[rednoah]

ISO 639-2/B is recommended because Plex / Kodi / friends expect those:
https://en.wikipedia.org/wiki/List_of_ISO_639-2_codes


That's what {plex} and {subt} use by default. This means that some detailed locales are simply not supported.


FileBot does not support en_US locale code as subtitle suffix. Not planned either. Nobody does it like that, so none of the developers think of this use case or test for this use case, so none of the players and tools can do anything with that.


You can always write your own custom format code to catch all of these special cases though, and then do something.

[ChefGregS]

Yeah, I totally get that. I had never seen that crap used. Not sure why that page even exists. But if no one goes that deep into categorizing then I am certainly not going to worry about it. You answered the question....

Thanks!!!

Greg

[LBKirk]

I'm having a similar issue with Synology filebot node and renaming srt files. I use a custom format to add the audio channels to the name of movies which works great but when it comes to subtitle files it names them incorrectly. Here's an example of a movie name (Valerie and Her Week of Wonders (1970) [2.0].mp4) and the subtitle was named (Valerie and Her Week of Wonders (1970).eng [2.0].srt) which places the [2.0] in a position where it's not recognized as the subtitle. It also has issues with multiple subs for a movie as you can see in the log. I'm not sure if I did something incorrectly but here's my output log. Also how do you stop it from checking open subs every time within Node? Thank you as always

Code: Select all

Run script [fn:amc] at [Tue Mar 24 14:20:13 EDT 2020]
Parameter: ut_label = Movie
Parameter: unsorted = y
Parameter: subtitles = eng
Parameter: clean = y
Parameter: skipExtract = y
Parameter: minLengthMS = 0
Parameter: plex = *****
Parameter: movieFormat = {plex} [{channels}]
Parameter: excludeList = .excludes
Argument[0]: /volume1/deluge/complete/YTS
Use excludes: /volume1/Media/Movies/.excludes (5271)
Ignore system path: /volume1/deluge/complete/YTS/@eaDir
Ignore hidden: /volume1/deluge/complete/YTS/Two Bits (1995) [1080p] [WEBRip] [YTS.MX]/Subs/.srt
Input: /volume1/deluge/complete/YTS/Death Race 4 Beyond Anarchy (2018) [1080p] [BluRay] [5.1] [YTS.MX]/Death.Race.4.Beyond.Anarchy.2018.1080p.BluRay.x264.AAC5.1-[YTS.MX].mp4
Input: /volume1/deluge/complete/YTS/Death Race 4 Beyond Anarchy (2018) [1080p] [BluRay] [5.1] [YTS.MX]/Subs/English.srt
Input: /volume1/deluge/complete/YTS/Death Race 4 Beyond Anarchy (2018) [1080p] [BluRay] [5.1] [YTS.MX]/Subs/SDH.eng.srt
Input: /volume1/deluge/complete/YTS/Fresh (1994) [1080p] [BluRay] [5.1] [YTS.MX]/Fresh.1994.1080p.BluRay.x264.AAC5.1-[YTS.MX].mp4
Input: /volume1/deluge/complete/YTS/Once Upon A Time In China II (1992) [1080p] [BluRay] [YTS.MX]/Once.Upon.A.Time.In.China.II.1992.1080p.BluRay.x264.AAC-[YTS.MX].mp4
Input: /volume1/deluge/complete/YTS/Once Upon A Time In China II (1992) [1080p] [BluRay] [YTS.MX]/Subs/English.srt
Input: /volume1/deluge/complete/YTS/Valerie And Her Week Of Wonders (1970) [1080p] [BluRay] [YTS.MX]/Subs/English.srt
Input: /volume1/deluge/complete/YTS/Valerie And Her Week Of Wonders (1970) [1080p] [BluRay] [YTS.MX]/Valerie.And.Her.Week.Of.Wonders.1970.1080p.BluRay.x264.AAC-[YTS.MX].mp4
Group: {Movie=true} => [Death.Race.4.Beyond.Anarchy.2018.1080p.BluRay.x264.AAC5.1-[YTS.MX].mp4, English.srt, SDH.eng.srt, Fresh.1994.1080p.BluRay.x264.AAC5.1-[YTS.MX].mp4, Once.Upon.A.Time.In.China.II.1992.1080p.BluRay.x264.AAC-[YTS.MX].mp4, English.srt, English.srt, Valerie.And.Her.Week.Of.Wonders.1970.1080p.BluRay.x264.AAC-[YTS.MX].mp4]
Get [English] subtitles for 4 files
Looking up subtitles by hash via OpenSubtitles
No matching subtitles found: /volume1/deluge/complete/YTS/Death Race 4 Beyond Anarchy (2018) [1080p] [BluRay] [5.1] [YTS.MX]/Death.Race.4.Beyond.Anarchy.2018.1080p.BluRay.x264.AAC5.1-[YTS.MX].mp4
No matching subtitles found: /volume1/deluge/complete/YTS/Fresh (1994) [1080p] [BluRay] [5.1] [YTS.MX]/Fresh.1994.1080p.BluRay.x264.AAC5.1-[YTS.MX].mp4
No matching subtitles found: /volume1/deluge/complete/YTS/Once Upon A Time In China II (1992) [1080p] [BluRay] [YTS.MX]/Once.Upon.A.Time.In.China.II.1992.1080p.BluRay.x264.AAC-[YTS.MX].mp4
No matching subtitles found: /volume1/deluge/complete/YTS/Valerie And Her Week Of Wonders (1970) [1080p] [BluRay] [YTS.MX]/Valerie.And.Her.Week.Of.Wonders.1970.1080p.BluRay.x264.AAC-[YTS.MX].mp4
Rename movies using [TheMovieDB]
Auto-detect movie from context [/volume1/deluge/complete/YTS/Death Race 4 Beyond Anarchy (2018) [1080p] [BluRay] [5.1] [YTS.MX]/Death.Race.4.Beyond.Anarchy.2018.1080p.BluRay.x264.AAC5.1-[YTS.MX].mp4]
Auto-detect movie from context [/volume1/deluge/complete/YTS/Fresh (1994) [1080p] [BluRay] [5.1] [YTS.MX]/Fresh.1994.1080p.BluRay.x264.AAC5.1-[YTS.MX].mp4]
Auto-detect movie from context [/volume1/deluge/complete/YTS/Once Upon A Time In China II (1992) [1080p] [BluRay] [YTS.MX]/Once.Upon.A.Time.In.China.II.1992.1080p.BluRay.x264.AAC-[YTS.MX].mp4]
Auto-detect movie from context [/volume1/deluge/complete/YTS/Valerie And Her Week Of Wonders (1970) [1080p] [BluRay] [YTS.MX]/Valerie.And.Her.Week.Of.Wonders.1970.1080p.BluRay.x264.AAC-[YTS.MX].mp4]
Auto-detect movie from context [/volume1/deluge/complete/YTS/Death Race 4 Beyond Anarchy (2018) [1080p] [BluRay] [5.1] [YTS.MX]/Subs/English.srt]
Auto-detect movie from context [/volume1/deluge/complete/YTS/Death Race 4 Beyond Anarchy (2018) [1080p] [BluRay] [5.1] [YTS.MX]/Subs/SDH.eng.srt]
Auto-detect movie from context [/volume1/deluge/complete/YTS/Once Upon A Time In China II (1992) [1080p] [BluRay] [YTS.MX]/Subs/English.srt]
Auto-detect movie from context [/volume1/deluge/complete/YTS/Valerie And Her Week Of Wonders (1970) [1080p] [BluRay] [YTS.MX]/Subs/English.srt]
[MOVE] from [/volume1/deluge/complete/YTS/Death Race 4 Beyond Anarchy (2018) [1080p] [BluRay] [5.1] [YTS.MX]/Death.Race.4.Beyond.Anarchy.2018.1080p.BluRay.x264.AAC5.1-[YTS.MX].mp4] to [/volume1/Media/Movies/Movies/Death Race - Beyond Anarchy (2018)/Death Race - Beyond Anarchy (2018) [5.1].mp4]
[MOVE] from [/volume1/deluge/complete/YTS/Death Race 4 Beyond Anarchy (2018) [1080p] [BluRay] [5.1] [YTS.MX]/Subs/English.srt] to [/volume1/Media/Movies/Movies/Death Race - Beyond Anarchy (2018)/Death Race - Beyond Anarchy (2018) CD1.eng [5.1].srt]
[MOVE] from [/volume1/deluge/complete/YTS/Death Race 4 Beyond Anarchy (2018) [1080p] [BluRay] [5.1] [YTS.MX]/Subs/SDH.eng.srt] to [/volume1/Media/Movies/Movies/Death Race - Beyond Anarchy (2018)/Death Race - Beyond Anarchy (2018) CD2.eng [5.1].srt]
[MOVE] from [/volume1/deluge/complete/YTS/Fresh (1994) [1080p] [BluRay] [5.1] [YTS.MX]/Fresh.1994.1080p.BluRay.x264.AAC5.1-[YTS.MX].mp4] to [/volume1/Media/Movies/Movies/Fresh (1994)/Fresh (1994) [5.1].mp4]
[MOVE] from [/volume1/deluge/complete/YTS/Once Upon A Time In China II (1992) [1080p] [BluRay] [YTS.MX]/Once.Upon.A.Time.In.China.II.1992.1080p.BluRay.x264.AAC-[YTS.MX].mp4] to [/volume1/Media/Movies/Movies/Once Upon a Time in China II (1992)/Once Upon a Time in China II (1992) [2.0].mp4]
[MOVE] from [/volume1/deluge/complete/YTS/Once Upon A Time In China II (1992) [1080p] [BluRay] [YTS.MX]/Subs/English.srt] to [/volume1/Media/Movies/Movies/Once Upon a Time in China II (1992)/Once Upon a Time in China II (1992).eng [2.0].srt]
[MOVE] from [/volume1/deluge/complete/YTS/Valerie And Her Week Of Wonders (1970) [1080p] [BluRay] [YTS.MX]/Valerie.And.Her.Week.Of.Wonders.1970.1080p.BluRay.x264.AAC-[YTS.MX].mp4] to [/volume1/Media/Movies/Movies/Valerie and Her Week of Wonders (1970)/Valerie and Her Week of Wonders (1970) [2.0].mp4]
[MOVE] from [/volume1/deluge/complete/YTS/Valerie And Her Week Of Wonders (1970) [1080p] [BluRay] [YTS.MX]/Subs/English.srt] to [/volume1/Media/Movies/Movies/Valerie and Her Week of Wonders (1970)/Valerie and Her Week of Wonders (1970).eng [2.0].srt]
[REFRESH] Refresh File Services (/volume1/Media/Movies/Movies/Death Race - Beyond Anarchy (2018))
[REFRESH] Refresh File Services (/volume1/Media/Movies/Movies/Fresh (1994))
[REFRESH] Refresh File Services (/volume1/Media/Movies/Movies/Once Upon a Time in China II (1992))
[REFRESH] Refresh File Services (/volume1/Media/Movies/Movies/Valerie and Her Week of Wonders (1970))
Processed 8 files

[rednoah]

e.g.

Code: Select all

{plex.derive{" [$channels]"}}

viewtopic.php?t=4116

[LBKirk]

Ah I had a feeling it was my setup. Again thank you

[cheaters]

I am having an issue where I am losing all but one srt file because there are more than one "eng.srt". I would like to keep all of them since some are only for scenes were English is not being spoken and some are continuous subtitles.

I am using the amc script in qBittorent. What do I need to add to the script to keep every English subtitle?

2_English.srt
3_English.srt

FileBot chooses one ( I am guessing the first in line) and changes it into this format after the amc script:

movietitle.eng.srt

I would like them to be save like this if possible, or whatever is most compatible.

movietitle_2.eng.srt
movietitle_3.eng.srt

My amc script in qBittorent:

Code: Select all

/Applications/FileBot.app/Contents/MacOS/filebot.sh -script fn:amc --output "/Volumes/PlexMedia" --action duplicate --conflict skip -non-strict --log-file amc.log --def excludeList=/Users/Username/.filebot/amc.excludes --def unsorted=y --def music=y --def subtitles=en --def minFileSize=0 --def minLengthMS=0 --def plex="127.0.0.1":"myplexkeyhere" "ut_dir=%F" "ut_kind=multi" "ut_title=%N" "ut_label=%L"